Projekte/web-base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Another MariaDB JSON fix

Browse Source
This commit is contained in:
Roman Hergenreder
2020-04-02 21:32:26 +02:00
parent f64e226703
commit 15762350d2
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/Driver/SQL/MySQL.class.php
View File

@@ -304,6 +304,7 @@ class MySQL extends SQL {
public function getColumnDefinition($column) {
$columnName = $column->getName();
$defaultValue = $column->getDefaultValue();
if ($column instanceof StringColumn) {
$maxSize = $column->getMaxSize();
@@ -330,15 +331,17 @@ class MySQL extends SQL {
$type = "BOOLEAN";
} else if($column instanceof JsonColumn) {
$type = "LONGTEXT"; # some maria db setups don't allow JSON here…
$defaultValue = NULL; # must be null :(
} else {
$this->lastError = "Unsupported Column Type: " . get_class($column);
return NULL;
}
$notNull = $column->notNull() ? " NOT NULL" : "";
$defaultValue = "";
if (!is_null($column->getDefaultValue()) || !$column->notNull()) {
if (!is_null($defaultValue) || !$column->notNull()) {
$defaultValue = " DEFAULT " . $this->getValueDefinition($column->getDefaultValue());
} else {
$defaultValue = "";
}
return "`$columnName` $type$notNull$defaultValue";